Change expected account name in NFTs tests to ENS domain #3494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have configured a ENS name for the `0x6f1b1f1feb01235e15a7962f16c389c7f8218ed6` address. We need to update the tests to reflect that.
e2e-tests/nfts.spec.ts
Outdated
| @@ -80,7 +80,7 @@ test.describe("NFTs", () => { | |||
| await page | |||
| .getByTestId("nft_account_filters") | |||
| .filter({ | |||
| hasText: /^(Phoenix|Matilda|Sirius|Topa|Atos|Sport|Lola|Foz)$/, | |||
| hasText: /^e2e\.testertesting\.eth$/, | |||
There was a problem hiding this comment.
let's add a const variable for it so we can reuse that name easily
There was a problem hiding this comment.
See b270c29.
There was a problem hiding this comment.
I would move it to the utils file so every test will have access to that name 😄
We're adding a `const` variable for the account name so that we can reuse it easily.
We're moving the account address and name to `utils`, so that they could be easily reused in other tests. We're numering the account, as likely there will be more acounts used in tests (different accounts may be needed for different purposes).
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have configured a ENS name for the
0x6f1b1f1feb01235e15a7962f16c389c7f8218ed6address. We need to update the tests to reflect that.Latest build: extension-builds-3494 (as of Thu, 22 Jun 2023 14:20:28 GMT).